[PATCH] D52276: [clangd] Add type boosting in code completion

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clangd/Quality.h:98
+  /// Whether the item matches the type expected in the completion context.
+  bool TypeMatchesPreferred = false;
   /// FIXME: unify with index proximity score - signals should be
----------------
you've inserted in the middle of the file proximity stuff :-)


================
Comment at: clangd/Quality.h:98
+  /// Whether the item matches the type expected in the completion context.
+  bool TypeMatchesPreferred = false;
   /// FIXME: unify with index proximity score - signals should be
----------------
sammccall wrote:
> you've inserted in the middle of the file proximity stuff :-)
Generally we'd put both context/symbol types as the signal here, rather than just whether they match, unless it's prohibitive. They'd get populated manually, and by merge() overloads, respectively.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52276