[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

Csaba Dabis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 20 06:20:02 PST 2018


Charusso added a comment.

In https://reviews.llvm.org/D54560#1301870, @NoQ wrote:

> Write down full messages in tests. When the message was updated from `'x' is moved'` to `Object 'x' is moved`, the tests were not updated because they kept passing because the former is still a sub-string of the latter.


It would not be cool to rewrite this `contains` effect to equality like in the regex file-checks? I have ran in the same problem and I was very surprised (for an hour) why my error-dumps does not show up on rewriting bug-report messages.


https://reviews.llvm.org/D54560





More information about the cfe-commits mailing list