[PATCH] D54694: [clangd] Replay preamble #includes to clang-tidy checks.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 19 02:32:00 PST 2018


sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric.

This is needed to correctly handle checks that use IncludeInserter,
which is very common.

I couldn't find a totally safe example of a check to enable for testing,
I picked modernize-deprecated-headers which some will probably hate.
We should get configuration working...

This depends on https://reviews.llvm.org/D54691 which ensures our calls to getFile(open=false)
don't break subsequent accesses via the FileManager.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54694

Files:
  clangd/ClangdUnit.cpp
  clangd/Diagnostics.cpp
  clangd/Headers.cpp
  clangd/Headers.h
  unittests/clangd/ClangdUnitTests.cpp
  unittests/clangd/HeadersTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54694.174575.patch
Type: text/x-patch
Size: 10596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181119/f3af1877/attachment-0001.bin>


More information about the cfe-commits mailing list