[PATCH] D54547: PTH-- Remove feature entirely-

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: include/clang/Driver/Options.td:261
   MetaVarName<"<gcc-path>">;
-def ccc_pch_is_pch : Flag<["-"], "ccc-pch-is-pch">, InternalDriverOpt,
-  HelpText<"Use lazy PCH for precompiled headers">;
----------------
The default behavior is exactly to use this flag.  I removed the flag since googling showed that it is never really used.


================
Comment at: lib/Frontend/CompilerInstance.cpp:384
+      getSourceManager(), getPCMCache(), *HeaderInfo, *this,
+      /*IdentifierInfoLookup=*/nullptr,
       /*OwnsHeaderSearch=*/true, TUKind);
----------------
IdentifierInfoLookup is an abstraction around ASTReader and (previously) PTHManager.  It seems that this abstraction could still be useful, so I've chosen to leave it in place.

When PTH wasn't enabled, PTHMgr was nullptr anyway, so this just uses that instead.


================
Comment at: unittests/Tooling/DiagnosticsYamlTest.cpp:85
             "    FilePath:        'path/to/source2.cpp'\n"
-            "    Replacements:    \n"
+            "    Replacements:    []\n"
             "...\n",
----------------
I'm unsure about what caused this change.  It seems to me that these two should be equivalent, and hopefully someone will correct me if I'm wrong.


Repository:
  rC Clang

https://reviews.llvm.org/D54547