[PATCH] D54407: Record the matcher type when storing a binding

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 11 15:57:42 PST 2018

aaron.ballman added a reviewer: sbenza.
aaron.ballman added a subscriber: sbenza.
aaron.ballman added a comment.

Adding @sbenza in case he has opinions on this approach. I think it's reasonable, but I also know that changes to the the AST matcher internals sometimes have unintended side effects with the various instantiations.

Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:189-190
+  using IDToNodeMap =
+      std::map<std::string, std::pair<ast_type_traits::DynTypedNode,
+                                      ast_type_traits::ASTNodeKind>>;
Use of a `std::pair` here is unfortunate because it's really hard to keep track of what first and second actually mean. A tiny aggregate with two named members would help.

  rC Clang


More information about the cfe-commits mailing list