[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

Ben via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 11 03:54:51 PST 2018

bobsayshilol added a comment.

In https://reviews.llvm.org/D53263#1294477, @kristina wrote:

> Huge apologies, it seems I can't get this to patch cleanly against my fork and therefore can't test it before committing, which is something I generally always do. I'll leave it to someone else. Again, huge apologies, hopefully you won't have to wait too long.

No worries! Thanks anyway for taking a look.

In https://reviews.llvm.org/D53263#1294488, @JDevlieghere wrote:

> The patch applies for me but has quite a few style violations. I'll fix those up before landing it. Also needs a test (I'll add the one from the description).

Ah I was trying to match the code around it and didn't think to run clang-tidy so I'll keep that in mind next time, and I didn't add a new test because just the assert in `Decl.cpp` was enough to flag up misuses with `check-clang` but I'm definitely not against adding more tests. Thanks for landing!

Thanks again everyone!



More information about the cfe-commits mailing list