[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 10 15:09:32 PST 2018


JonasToth added a comment.

Thank you for checking these two projects!

In https://reviews.llvm.org/D53974#1294375, @ztamas wrote:

> I have the result after running the current version of the check on LibreOffice.
>
> Found around 50 new issues were hidden by macros:
>  https://cgit.freedesktop.org/libreoffice/core/commit/?id=afbfe42e63cdba1a18c292d7eb4875009b0f19c0
>
> Also found some new false positives related to macros. The number of all false positives is around 38, which is still seems good to me.


I would be very interested why these false positives are created. Is there a way to avoid them and maybe it makes sense to already add `FIXME` at the possible places the check needs improvements.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53974





More information about the cfe-commits mailing list