[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 10 12:37:24 PST 2018

Szelethus added inline comments.

Comment at: clang-tidy/readability/RedundantPreprocessorCheck.cpp:19-22
+struct Entry {
+  SourceLocation Loc;
+  std::string MacroName;
vmiklos wrote:
> Szelethus wrote:
> > This is a way too general name in my opinion. Either include comments that describe it, or rename it (preferably both).
> Renamed to `PreprocessorCondition`, hope it helps. :-)
I actually meant it for `Entry`, if you hover your mouse over an inline comment, you can see which lines it applies to. Sorry for the confusing communication :D


More information about the cfe-commits mailing list