[PATCH] D54379: Add Hurd support

Kristina Brooks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 10 07:26:52 PST 2018


kristina added reviewers: kristina, clang.
kristina added a comment.

A few style naming/comments.



================
Comment at: lib/Driver/ToolChains/Hurd.cpp:36
+  // clever.
+  switch (TargetTriple.getArch()) {
+  default:
----------------
Does this need a switch? Wouldn't an `if` be sufficient?


================
Comment at: lib/Driver/ToolChains/Hurd.cpp:106
+    CIncludeDirs.split(dirs, ":");
+    for (StringRef dir : dirs) {
+      StringRef Prefix =
----------------
Variable names should be capitalized.


================
Comment at: lib/Driver/ToolChains/Hurd.cpp:125
+    break;
+  default:
+    break;
----------------
Default should generally be the first case, if present.


Repository:
  rC Clang

https://reviews.llvm.org/D54379





More information about the cfe-commits mailing list