[PATCH] D54120: [python] Support PathLike filenames and directories

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 10 02:51:39 PST 2018

mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

Comment at: bindings/python/clang/cindex.py:133
+except AttributeError:
+    def fspath(string):
+        return string
Optionally: this is now a little bit nitpick but could you use a different variable name (e.g. commonly used elsewhere `x`)? This could be a little bit confusing with Python's `string` module.


More information about the cfe-commits mailing list