[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed
Peter Collingbourne via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 9 15:59:21 PST 2018
pcc added inline comments.
Comment at: docs/LTOVisibility.rst:9
unit's *LTO unit* is the subset of the linkage unit that is linked together
-using link-time optimization; in the case where LTO is not being used, the
-linkage unit's LTO unit is empty. Each linkage unit has only a single LTO unit.
+using link-time optimization; in the case where LTO units are not being used,
+the linkage unit's LTO unit is empty. Each linkage unit has only a single LTO
It's a little confusing to talk about "LTO units" as a property of a translation unit when there is only one LTO unit per linkage unit. I think this should say that an LTO unit is the subset of the linkage unit compiled with certain flags. Then in the rest of the document you can talk about translation units that are either part of or not part of the LTO unit.
More information about the cfe-commits