[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 9 09:54:26 PST 2018

aaron.ballman added a comment.

In https://reviews.llvm.org/D54258#1292129, @richardmembarth wrote:

> I think it's not so easy to provide such tests for CUDA.
>  CUDA memory space specifiers are implemented via attributes, e.g. `#define __shared__ __attribute__((shared))`.
>  As a result of this, they are pretty-printed via a different code path.
>  In my example, I call `Ctx.getAddrSpaceQualType(QT, LangAS::cuda_shared)`, which is then pretty-printed via the code above.
>  Any hints how to provide tests for this one?

If there's no way to trigger a different spelling that a user would see, why is this change needed?

  rC Clang


More information about the cfe-commits mailing list