[PATCH] D54309: [AST] Allow limiting the scope of common AST traversals (getParents, RAV).

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 9 06:45:33 PST 2018

sammccall created this revision.
sammccall added reviewers: klimek, ioeric.
Herald added subscribers: cfe-commits, mgorny.

The goal is to allow analyses such as clang-tidy checks to run on a
subset of the AST, e.g. "only on main-file decls" for interactive tools.

Today, these become "problematically global" by running RecursiveASTVisitors
rooted at the TUDecl, or by navigating up via ASTContext::getParent().

The scope is restricted using a set of top-level-decls that RecursiveASTVisitors
should be rooted at. This also applies to the visitor that populates the
parent map, and so the top-level-decls are considered to have no parents.

This patch makes the traversal scope a mutable property of ASTContext.
The more obvious way to do this is to pass the top-level decls to
relevant functions directly, but this has some problems:

- it's error-prone: accidentally mixing restricted and unrestricted scopes is a performance trap. Interleaving multiple analyses is common (many clang-tidy checks run matchers or RAVs from matcher callbacks)
- it doesn't map well to the actual use cases, where we really do want *all* traversals to be restricted.
- it involves a lot of plumbing in parts of the code that don't care about traversals.

This approach was tried out in https://reviews.llvm.org/D54259 and https://reviews.llvm.org/D54261, I wanted to like it
but it feels pretty awful in practice.

Caveats: to get scope-limiting behavior of RecursiveASTVisitors, callers
have to call the new TraverseAST(Ctx) function instead of TraverseDecl(TU).
I think this is an improvement to the API regardless.

  rC Clang



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54309.173317.patch
Type: text/x-patch
Size: 24934 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181109/ad6b3db8/attachment-0001.bin>

More information about the cfe-commits mailing list