[PATCH] D54281: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 8 15:59:46 PST 2018

JonasToth added inline comments.

Comment at: clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:65
+          unless(isInsideOfRangeBeginEndStmt()),
+          unless(hasSourceExpression(ignoringParenCasts(stringLiteral()))))
aaron.ballman wrote:
> I think you want `ignoringParens()` instead, no?
That doesn't seem to compile, it only applies to `QualType`. There is `ignoringParenCasts` and `ignoringParenImpCasts` that match on everything. Ignoring the imp-casts is not what we want.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list