[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.
Filipe Cabecinhas via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 8 08:10:54 PST 2018
filcab added a comment.
Sorry to ressurect this review, but I have a few questions:
- What kind of functions fail?
- Are there bugzillas to track these?
- How can a compiler expect to have blacklists for "all" its CFI clients? (I'm ok with having a default for "most-used, well-known, problematic functions", e.g: functions in libstdc++ or libc++)
- clang/compiler-rt don't seem to have a default blacklist, what should the contents be? This patch seems to be saying "There are some well-known functions that should never be instrumented with CFI, I'll provide a list of names", which doesn't really seem possible to do in general, for "most" CFI-toolchain clients. As I see it, each client will need to have their own blacklist, and provide it as an argument if needed. Which brings us to:
- If I pass `-fsanitize-blacklist=my_blacklist.txt` I still get an error. This is not ideal, as I might be working on the blacklist to include in my toolchain/program.
I don't think we should have an error that is default enabled for this issue. At most a warning (+ `-Werror`) if there was no blacklist passed in nor found in the toolchain resource directory.
P.S: Sorry for only noticing this so much later.
More information about the cfe-commits