[PATCH] D53675: [WebAssembly] Lower select for vectors

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 7 21:37:30 PST 2018

tlively added a comment.

In https://reviews.llvm.org/D53675#1290660, @aheejin wrote:

> I tried to add `ISD::SELECT` in the expansion list, like
>   for (auto Op : {ISD::VSELECT, ISD::SELECT_CC, ISD::SELECT}) {
>     ...
>   }
> And the code generation apparently works for current test `simd-select.ll`. I'm not sure if it's optimal though. Could you check again?

I'm not sure what I did before, but you're totally right. Letting the expander take care of selects yields the same code in most places and actually allows some DAGCombine optimizations that weren't possible before.



More information about the cfe-commits mailing list