[PATCH] D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 7 10:37:49 PST 2018

MaskRay added inline comments.

Comment at: clangd/index/Index.h:84
 inline bool operator==(const SymbolLocation &L, const SymbolLocation &R) {
-  return std::tie(L.FileURI, L.Start, L.End) ==
-         std::tie(R.FileURI, R.Start, R.End);
+  return std::make_tuple(llvm::StringRef(L.FileURI), L.Start, L.End) ==
+         std::make_tuple(llvm::StringRef(R.FileURI), R.Start, R.End);
The `StringRef(const char*)` constructor calls `strlen`. Do you believe this does not have noticeable performance issue?

(A minor point: `tuple::operator<` calls `operator<` of its components in a not very efficient way. The compiler does not know `compare(a, b) < 0` implies `compare(b, a) > 0` and `strcmp` may end up being called twice.)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list