[PATCH] D54187: Add debuginfo-tests that use cdb on Windows
Adrian Prantl via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 7 09:17:58 PST 2018
aprantl added a comment.
In https://reviews.llvm.org/D54187#1290317, @zturner wrote:
> In https://reviews.llvm.org/D54187#1290297, @aprantl wrote:
> > In https://reviews.llvm.org/D54187#1290293, @zturner wrote:
> > > Especially since as far as I can tell, nobody has even run debuginfo-tests since late August, because it was actually broken by r341135 on August 30 (fixed in r346060 yesterday)
> > Can you please refrain from making such general statements? They distract from the discussion.
> > http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/ runs the debuginfo-tests continuously. There is a configuration issue that prevents it from running the ASAN subset of the tests at the moment.
> The issue introduced by r341135 doesn't seem related to ASAN unless I'm misunderstanding the issue. Were debuginfo-tests passing on that bot even before r346060 landed?
r341135 is a fix to `lit.site.cfg.py.in` my best guess is that because clang-stage1-cmake-RA-expensive runs the debuginfo-tests inside the llvm/tools/clang/test/debuginfo-tests subdirectory that doesn't get used in that configuration?
More information about the cfe-commits