[PATCH] D54202: [clangd] Drop namespace references in the index.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 7 06:58:36 PST 2018

hokein added inline comments.

Comment at: clangd/index/SymbolCollector.cpp:359
     return true;
-  if (CollectRef &&
+  if (CollectRef && !isa<NamespaceDecl>(ND) &&
       (Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID()))
kadircet wrote:
> Why not handle in `shouldCollectSymbol` ?
`shouldCollectSymbol` is shared between the code collecting symbols and the code collecting references, we still want to collect namespace symbols.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list