[PATCH] D53651: [clangd] Use thread pool for background indexing.
Mikael Holmén via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 7 01:32:07 PST 2018
uabelho added a comment.
I've got a post-review comment about the use of SCHED_IDLE vs the needed gcc version.
Comment at: clang-tools-extra/trunk/clangd/Threading.cpp:110
+ Priority == ThreadPriority::Low ? SCHED_IDLE : SCHED_OTHER, &priority);
I noticed that when I compile this with gcc 5.4.0, I get a compilation error about SCHED_IDLE not being defined.
Indeed, if I look in sched.h used with gcc 5.4.0, these are the SCHED_* definitions:
/* Scheduling algorithms. */
#define SCHED_OTHER 0
#define SCHED_FIFO 1
#define SCHED_RR 2
# define SCHED_BATCH 3
I suppose SCHED_IDLE was added in some later version...
it says that gcc 4.8 should work, but it doesn't now then?
More information about the cfe-commits