[PATCH] D54169: [clang-tidy] Zircon <fbl/limits.h> -> <limits>

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 6 18:47:24 PST 2018

juliehockett added inline comments.

Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47
+    SrcMgr::CharacteristicKind FileType) {
+  if (FileName == "fbl/limits.h") {
+    unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1;
aaron.ballman wrote:
> Does this also work on platforms where the path separator is `\` instead of `/`? What about case insensitive file systems where it may be spelled `LiMiTs.H`? Does this properly handle a case like:
> ```
> #define LIMITS "fbl/limits.h"
> #include LIMITS
> ```
> (Should add test cases for all of these scenarios.)
Since this is a migration for our own codebase, we know we don't have any code that uses any variation other than <fbl/limits.h> and so hardcoding that is acceptable to us here.

Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:70
+void FblLimitsCheck::registerMatchers(MatchFinder *Finder) {
+  Finder->addMatcher(varDecl(hasType(cxxRecordDecl(allOf(
+                                 hasDeclContext(namespaceDecl(hasName("fbl"))),
aaron.ballman wrote:
> Can users specialize `fbl::numeric_limits` for custom integral types like they can for `std::numeric_limits`? If so, that should maybe be covered with a checker as well.
Technically, they could, but there are no instances of it in the codebase.


More information about the cfe-commits mailing list