[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 6 13:20:45 PST 2018

Eugene.Zelenko added inline comments.

Comment at: clang-tools-extra/clang-tidy/zircon/FblMoveCheck.cpp:61
+    // Add in the <utility> header.
+    if (auto IncludeFixit =
+            Inserter->CreateIncludeInsertion(SM.getFileID(Start), "utility",
Please don't use auto when type could not be deduced from statement.

Comment at: clang-tools-extra/docs/ReleaseNotes.rst:188
+  This check is part of the migration checks for moving Zircon user code to use
+  the C++ standard library. It suggests converting uses of ``fbl::move`` to
I think first statement is not necessary. Second should start from //Suggests//. Will be good idea to synchronize it with documentation.


More information about the cfe-commits mailing list