[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 6 13:14:10 PST 2018

JonasToth added a comment.

> At least the clang-tidy quiet mode is trivial to implement. Maybe instead of `--quiet` we could have `--stdout=<output_format>` where `output_format` can be one of `none`, `diag`, `yaml` and in the future possibly `json` (requested here: http://lists.llvm.org/pipermail/cfe-dev/2018-October/059944.html) or `cbor`, to address the binary output suggestion from @hokein.

Yes, it would slighlty duplicate `export-fixes` but i think that is not a big issue.
I think the first steps would be using parallel execution within clang-tidy itself.
After that we can extract the deduplication logic from apply-replacements (if it is actually suitable!) or deduplicate in the `diag()` emitting phase. A thing we have to keep in mind, that deduplication must happen to the whole `warning: blaaa\n note: blaa \n note: 'aslkdjad' here comes the only change between two different warnings` construct.
If we don't group the diagnostics properly we have a bad time.

That said, would you agree to have the parser-based deduplication as an developer-only optin solution for now? :)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list