[PATCH] D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 6 12:22:55 PST 2018

jkorous requested review of this revision.
jkorous added a comment.

I tried to move the getNearestOption() to it's only client - EmitUnknownDiagWarning() but it turned out to be a significant change because of clang/Basic/DiagnosticGroups.inc use in DiagnosticIDs.cpp.
I suggest we leave that for eventual future refactoring since it would blow up scope of this patch a lot.

  rC Clang


More information about the cfe-commits mailing list