r345591 - [CodeGen] Disable the machine verifier on a ThinLTO test

[Francis Visoiu Mistrih via cfe-commits]

Thanks for the suggestion, I think it’s reasonable since it’s all due to:

* ICALL_BRANCH_FUNNEL: Bad machine code: Explicit definition marked as use https://bugs.llvm.org/show_bug.cgi?id=39436 <https://bugs.llvm.org/show_bug.cgi?id=39436>.

I’ll look into it.

> On 5 Nov 2018, at 19:13, David Blaikie <dblaikie at gmail.com> wrote:
> 
> If ThinLTO doesn't pass the machine verifier - should it maybe be turned off at the thinlto level in general, rather than for this specific test?
> 
> On Tue, Oct 30, 2018 at 5:20 AM Francis Visoiu Mistrih via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
> Author: thegameg
> Date: Tue Oct 30 05:18:33 2018
> New Revision: 345591
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=345591&view=rev <http://llvm.org/viewvc/llvm-project?rev=345591&view=rev>
> Log:
> [CodeGen] Disable the machine verifier on a ThinLTO test
> 
> This allows us to turn the machine verifier on by default on X86.
> 
> Modified:
>     cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll
> 
> Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll?rev=345591&r1=345590&r2=345591&view=diff <http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll?rev=345591&r1=345590&r2=345591&view=diff>
> ==============================================================================
> --- cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll (original)
> +++ cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll Tue Oct 30 05:18:33 2018
> @@ -6,7 +6,9 @@
> 
>  ; RUN: opt -thinlto-bc -o %t.o %s
> 
> +; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39436.
>  ; RUN: llvm-lto2 run -thinlto-distributed-indexes %t.o \
> +; RUN:   -verify-machineinstrs=0 \
>  ; RUN:   -o %t2.index \
>  ; RUN:   -r=%t.o,test,px \
>  ; RUN:   -r=%t.o,_ZN1A1nEi,p \
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181106/46f2bf87/attachment.html>