[PATCH] D54077: [clangd] Implemented DraftFileSystem

Lutsenko Danil via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 6 02:44:32 PST 2018

LutsenkoDanil added a comment.

@sammccall Thank you for detailed explanation!

In https://reviews.llvm.org/D54077#1288387, @sammccall wrote:

> Someone mentioned to me that the interaction-between-features argument wasn't clear here:
> - we **don't** currently update diagnostics for `A.cc` when `A.h` is edited
> - we should, this seems more obvious & important than what we do with drafts
> - this interacts badly with using draft state, as this patch proposes - there are too many edits

I already made a patch which introduces such behavior (not uploaded here yet), and looks like it works well with draft fs: diagnostics updates for depended files in 'real-time' on typing for opened files and no seen performance glitches, in multi-threaded mode at least.
I suggest continue discussion when/if dependencies tracking will be implemented and real performance reduce introduced by this patch can be checked with real code.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list