[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

Tony Tye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 20:16:05 PST 2018

t-tye added a comment.

In https://reviews.llvm.org/D53153#1288127, @rjmccall wrote:

> In https://reviews.llvm.org/D53153#1288112, @rjmccall wrote:
> > But do you want to support *dynamically* linking object files?  Because that's what visibility is about.
> To be specific, if you don't have multiple levels of linking — doing a slower and relatively more expensive link to form a self-contained unit of code distribution, then doing a faster link to form a runnable program from multiple independently-distributed such units — then visibility isn't really doing anything for you.

Currently the AMDGPU code objects are fully linked dynamically loader shared libraries. They are not relocatable code objects. This allows fewer and cheaper relocations and a smaller (dynsym) symbol table for the runtime loader.


More information about the cfe-commits mailing list