[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 17:18:14 PST 2018

rjmccall added a comment.

In https://reviews.llvm.org/D53153#1288083, @arsenm wrote:

> In https://reviews.llvm.org/D53153#1288059, @rjmccall wrote:
> > I agree with Richard that I'm not sure what the point of supporting frontend visibility settings in OpenCL is.  If you want the "everything is internal to the image" optimization, presumably you can just infer visibility on everything in a pass over the IR.
> Eventually we want to support linking object files, and setting the visibility in the IR won't be aware of any user specified visibility

But do you want to support *dynamically* linking object files?  Because that's what visibility is about.


More information about the cfe-commits mailing list