[PATCH] D54061: [clang-tidy] run() doesn't update the SourceManager.

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 5 01:21:49 PST 2018

JonasToth added a comment.

> Theoretically, we could replace `ClangTidyCheck::check` with `ClangTidyCheck::run`, but I'm not sure it is worth, `ClangTidyCheck::check` is a public API, and is widely-used (for all clang-tidy checks), replacing it requires large changes (although it is one-line change), it might break downstream clang-tidy checks.

We can add a deprecation warning and remove the `check` method in the
next version?

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list