[PATCH] D53982: Output "rule" information in SARIF

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:237-242
+#define GET_CHECKERS
+#define CHECKER(FULLNAME, CLASS, CXXFILE, HELPTEXT, GROUPINDEX, HIDDEN)        \
+  .Case(FULLNAME, HELPTEXT)
+#include "clang/StaticAnalyzer/Checkers/Checkers.inc"
+#undef CHECKER
+#undef GET_CHECKERS
----------------
Szelethus wrote:
> Hmmm, this won't handle checkers loaded from plugins.
I don't immediately know the solution is to this, but when you invoke clang with `-cc1 -analyzer-checker-help`, plugin checkers are also displayed, and [[ https://github.com/llvm-mirror/clang/blob/master/lib/StaticAnalyzer/Frontend/CheckerRegistration.cpp#L150 | this is line that magically does it ]].
Maybe store the plugins in `AnalyzerOptions`, and move `ClangCheckerRegistry` to `include/clang/StaticAnalyzer/Frontend`?


https://reviews.llvm.org/D53982