r345993 - Didn't -> didnt, because #errors complains about untermianted '

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 2 10:23:07 PDT 2018


On Fri, Nov 2, 2018 at 12:34 PM Kristof Umann via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> Author: szelethus
> Date: Fri Nov  2 09:32:15 2018
> New Revision: 345993
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345993&view=rev
> Log:
> Didn't -> didnt, because #errors complains about untermianted '

Why not quote the string instead of making it ungrammatical? e.g.,

#error "If you didn't include this file with the intent of generating
methods, define both 'ANALYZER_OPTION' " \
           "and 'ANALYZER_OPTION_DEPENDS_ON_USER_MODE' macros!"

~Aaron

>
> Modified:
>     cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
>
> Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def?rev=345993&r1=345992&r2=345993&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def (original)
> +++ cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def Fri Nov  2 09:32:15 2018
> @@ -41,14 +41,14 @@
>
>  #ifdef ANALYZER_OPTION
>  #ifndef ANALYZER_OPTION_DEPENDS_ON_USER_MODE
> -#error If you didn't include this file with the intent of generating methods, \
> +#error If you didnt include this file with the intent of generating methods, \
>  define both 'ANALYZER_OPTION' and 'ANALYZER_OPTION_DEPENDS_ON_USER_MODE' macros!
>  #endif
>  #endif
>
>  #ifndef ANALYZER_OPTION_DEPENDS_ON_USER_MODE
>  #ifdef ANALYZER_OPTION
> -#error If you didn't include this file with the intent of generating methods, \
> +#error If you didnt include this file with the intent of generating methods, \
>  define both 'ANALYZER_OPTION' and 'ANALYZER_OPTION_DEPENDS_ON_USER_MODE' macros!
>  #endif
>  #endif
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list