[PATCH] D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

Tom Weaver via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 2 08:21:46 PDT 2018


TWeaver created this revision.
TWeaver added a reviewer: sammccall.
Herald added subscribers: llvm-commits, xazax.hun.

r345961 introduced a path check in .\tools\clang\tools\extra\test\clang-tidy\clang-tidy-run-with-database.cpp.

r345961 added a check line for a path that only handled / on unix machines and not \ on windows machines.

This patch handles both cases.


Repository:
  rL LLVM

https://reviews.llvm.org/D54036

Files:
  llvm/tools/clang/tools/extra/test/clang-tidy/clang-tidy-run-with-database.cpp


Index: llvm/tools/clang/tools/extra/test/clang-tidy/clang-tidy-run-with-database.cpp
===================================================================
--- llvm/tools/clang/tools/extra/test/clang-tidy/clang-tidy-run-with-database.cpp
+++ llvm/tools/clang/tools/extra/test/clang-tidy/clang-tidy-run-with-database.cpp
@@ -11,7 +11,7 @@
 
 // Regression test: shouldn't crash.
 // RUN: not clang-tidy --checks=-*,modernize-use-nullptr -p %T %T/compilation-database-test/b/not-exist -header-filter=.* 2>&1 | FileCheck %s -check-prefix=CHECK-NOT-EXIST
-// CHECK-NOT-EXIST: Error while processing {{.*}}/not-exist.
+// CHECK-NOT-EXIST: Error while processing {{.*[/\\]}}not-exist.
 // CHECK-NOT-EXIST: unable to handle compilation
 // CHECK-NOT-EXIST: Found compiler error
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54036.172363.patch
Type: text/x-patch
Size: 770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181102/a22a409f/attachment.bin>


More information about the cfe-commits mailing list