[PATCH] D52984: [analyzer] Checker reviewer's checklist

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 2 07:31:21 PDT 2018


xazax.hun updated this revision to Diff 172354.
xazax.hun added a comment.

This new version based on the bullets by NoQ. I also included some additional ones from other lists and added some new ones, e.g. the NamedDecl::getName will fail if the name of the decl is not a single token. I also reordered a bit. Advice that is more advanced and guidelines that are less likely to be violated should be closer to the bottom of the list.

Please let me know if I forgot something or the order of the list should be changed.


https://reviews.llvm.org/D52984

Files:
  www/analyzer/checker_dev_manual.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52984.172354.patch
Type: text/x-patch
Size: 7381 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181102/2d827392/attachment-0001.bin>


More information about the cfe-commits mailing list