[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

Takuto Ikuta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 2 06:46:03 PDT 2018


takuto.ikuta added a comment.

Thank you! I'll submit this if other people does not have other comments.



================
Comment at: clang/test/CodeGenCXX/dllexport-no-dllexport-inlines.cpp:9
+// RUN:     -emit-llvm -O1 -o - |                                       \
+// RUN:     FileCheck --check-prefix=CHECK %s
+
----------------
hans wrote:
> Did the "EXPORTINLINE" check-prefix get lost here?
Good catch!


https://reviews.llvm.org/D51340





More information about the cfe-commits mailing list