[PATCH] D52984: [analyzer] Checker reviewer's checklist

Umann Kristóf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 1 14:41:15 PDT 2018


Szelethus added inline comments.


================
Comment at: www/analyzer/checker_dev_manual.html:720
+<li>Are Checkers.td and the CMakeLists entry alphabetically ordered?</li>
+</ul>
+
----------------
aaron.ballman wrote:
> Do we want to add an item for "Is the help text for the checker a useful description of what the check does?" or something along those lines? I happened to be looking at the help text for checkers and some of it is... less than ideal ("Checks MPI code", etc).
Strongly agreed.


Repository:
  rC Clang

https://reviews.llvm.org/D52984





More information about the cfe-commits mailing list