[PATCH] D53985: Use C++11 fallthrough attribute syntax when available and add a break

[Reid Kleckner via Phabricator via cfe-commits]

rnk added subscribers: aaron.ballman, rsmith.
rnk added a comment.

In https://reviews.llvm.org/D53985#1284196, @ldionne wrote:

> Would it make sense to add the GNU spelling to the attribute in Clang?


I'll redirect that question to @rsmith and @aaron.ballman. I have a vague recollection that it was considered and rejected, but that decision may have predated GCC 7.

In any case, libc++ needs the [[clang::fallthrough]] spelling to support old versions of clang in C++11 mode.

Thanks!


https://reviews.llvm.org/D53985