[PATCH] D53953: [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC

[Sam McCall via Phabricator via cfe-commits]

sammccall marked an inline comment as done.
sammccall added a comment.

BTW, the missing "X doesn't exist" is because Tooling.cpp turns off driver diagnostics for nonexistent files, because clang/driver wasn't VFS-aware... in 2011.
I'll send patches to fix this if there isn't too much fallout (Driver still needs to be fixed to **use** its VFS in this case, and then Tooling needs to enable the check).

This means you'll get:

  error: no such file or directory: '/path/to/file.cpp'
  error: no input files

Clang-tidy will decorate these with `[clang-diagnostic-error]`, but that's a separate bug I guess.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53953