[PATCH] D53949: [clang][CodeGen] Implicit Conversion Sanitizer: discover the world of CompoundAssign operators

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 31 14:12:01 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D53949#1282870, @lebedev.ri wrote:

> In https://reviews.llvm.org/D53949#1282866, @regehr wrote:
>
> > This patch doesn't appear to yet fix the "x++" or "x--" cases.
>
>
> It won't, the increment/decrement happens on the original type, there is no cast there. https://godbolt.org/z/WuWA62
>  Those cases are for normal signed/unsigned overflow checks.


Hm, huh, and `-fsanitize=undefined -fsanitize=integer` do not handle that too, great catch!
https://godbolt.org/z/lPB7n4
I'll look into that next i guess :)


Repository:
  rC Clang

https://reviews.llvm.org/D53949





More information about the cfe-commits mailing list