[PATCH] D53025: [clang-tidy] implement new check for const return types.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 31 11:41:09 PDT 2018


aaron.ballman added a comment.

In https://reviews.llvm.org/D53025#1282423, @ymandel wrote:

> Aaron, Jonas,
>
> Thank you both so much for being fantastic reviewers!  This was my first experience contributing to clang (upstream) and it has been extremely positive.


Congratulations on contributing your first patch!

> In https://reviews.llvm.org/D53025#1282194, @aaron.ballman wrote:
> 
>> This LGTM, thank you for working on this check!
> 
> 
> Great! I don't have SVN commit access.  Can one of you commit this?

I'm happy to do so, but the patch currently does not apply cleanly to the ToT. Can you rebase your patch on trunk and update the review with it?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53025





More information about the cfe-commits mailing list