[PATCH] D53850: Declares __cpu_model as dso local

Haibo Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 30 14:14:16 PDT 2018


hhb added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:9013
       Features, llvm::ConstantInt::get(Int32Ty, FeaturesMask));
   return Builder.CreateICmpNE(Bitset, llvm::ConstantInt::get(Int32Ty, 0));
 }
----------------
craig.topper wrote:
> This code looks to be out of date. It's missing the changes from r344832 that added another runtime variable that presumably has the same issue.
By the way, what is the reason for gcc to add a separate __cpu_feature2, but not adding an element to __cpu_model.__cpu_features array?


https://reviews.llvm.org/D53850





More information about the cfe-commits mailing list