[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

Tue Oct 30 13:36:15 PDT 2018

tejohnson added a comment.

In https://reviews.llvm.org/D53524#1279288, @tejohnson wrote:

> In https://reviews.llvm.org/D53524#1276038, @pcc wrote:
>
> > In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote:
> >
> > > In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote:
> > >
> > > > Can we detect that TUs compiled with -flto-unit are being mixed with those not built without -flto-unit at the thin link time and issue an error?
> > >
> > >
> > > This would be doable pretty easily. E.g. add a flag at the index level that the module would have been split but wasn't. Users who get the error and want to support always-enabled CFI could opt in via -flto-unit.
> >
> >
> > Yes. I don't think we should make a change like this unless there is something like that in place, though. The documentation (LTOVisibility.rst) needs to be updated too.
>
>
> Ok, let me work on that now and we can get that in before this one.

Mailed https://reviews.llvm.org/D53890 for this part.

Repository:
  rC Clang

https://reviews.llvm.org/D53524