[PATCH] D53787: [Sema] Use proper visibility for global new and delete declarations

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 29 20:13:22 PDT 2018


phosek added a comment.

In https://reviews.llvm.org/D53787#1279899, @rsmith wrote:

> Replacing the global new and delete is supposed to be a whole-program operation (you only get one global allocator). Otherwise you couldn't allocate memory in one DSO and deallocate it in another. (And nor could inline functions etc.)
>
> If you really want to do this weird thing, and you understand what you're getting yourself into, I don't see a problem with having a dedicated flag for it, but don't break all existing users of -fvisibility=.


That sounds reasonable, do you have any suggestion for the name of such flag?


Repository:
  rC Clang

https://reviews.llvm.org/D53787





More information about the cfe-commits mailing list