[PATCH] D53856: [analyzer] Put llvm.Conventions back in alpha

[Umann Kristóf via Phabricator via cfe-commits]

Szelethus added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp:193-195
 static bool AllocatesMemory(QualType T) {
   return IsStdVector(T) || IsStdString(T) || IsSmallVector(T);
 }
----------------
The `StringRef`part of this checker doesn't do a thing for me at all (even after a good amount of trying to make it work), but this part of the checker suffers a lot too.

I'm sure we can some up with better ways for this function (and every single one in this file to be honest) now that almost a decade has passed.


https://reviews.llvm.org/D53856