[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

[Alexander Zaitsev via Phabricator via cfe-commits]

ZaMaZaN4iK marked 3 inline comments as done.
ZaMaZaN4iK added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:19
+//   of casting an integer value that is out of range
+//===----------------------------------------------------------------------===//
+
----------------
Szelethus wrote:
> ZaMaZaN4iK wrote:
> > aaron.ballman wrote:
> > > If this check is intended to conform to CERT's INT50-CPP rule, you should put a link to the wiki entry for it here as well.
> > Which wiki entry do you mean?
> Maybe this one? https://wiki.sei.cmu.edu/confluence/display/cplusplus/INT50-CPP.+Do+not+cast+to+an+out-of-range+enumeration+value
Added a note about CERT's coding standard recommendaation. Didn't add the reference to web page because web pages can become broken. I think standard and check names are quite good explanation for here


https://reviews.llvm.org/D33672