[PATCH] D53605: [AST] Refactor PredefinedExpr

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 26 21:22:00 PDT 2018


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: include/clang/AST/Stmt.h:279
+    /// in PredefinedExpr::IdentType.
+    unsigned Type : 4;
+
----------------
rjmccall wrote:
> Since you're changing this around anyway, please make it a "kind" rather than a "type".  Even if it's just the field name for now, it's progress.
Thank you!  That was more than I expected, but it's definitely better this way.


Repository:
  rC Clang

https://reviews.llvm.org/D53605





More information about the cfe-commits mailing list