[PATCH] D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGObjC.cpp:2480
+                         SuppressResultRetain);
   }
 
----------------
vsapsai wrote:
> rjmccall wrote:
> > This switch is just checking what you already computed as `SuppressResultRetain`.  Please just assert in the second case that the qualifier is `OCL_Weak`.
> > 
> > Also, please stay consistent with the surrounding capitalization of local variables.
> Not entirely sure I understand the comment about switch correctly. Will change the code according to my understanding.
That's exactly what I was asking for, thank you.


https://reviews.llvm.org/D53674