[PATCH] D53771: [clang-tidy] Avoid C arrays check

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added inline comments.


================
Comment at: docs/clang-tidy/checks/list.rst:13
    abseil-redundant-strcat-calls
-   abseil-string-find-startswith
    abseil-str-cat-append
----------------
spurious change


================
Comment at: docs/clang-tidy/checks/list.rst:154
    hicpp-undelegated-constructor (redirects to bugprone-undelegated-constructor) <hicpp-undelegated-constructor>
+   hicpp-uppercase-literal-suffix (redirects to readability-uppercase-literal-suffix) <hicpp-uppercase-literal-suffix>
    hicpp-use-auto (redirects to modernize-use-auto) <hicpp-use-auto>
----------------
here as well


================
Comment at: docs/clang-tidy/checks/misc-avoid-c-arrays.rst:51
+  }
+
+  ...
----------------
The last two lines do not add value, i think you can safely remove them


================
Comment at: test/clang-tidy/misc-avoid-c-arrays.cpp:14
+
+template <typename T, int Size>
+class array {
----------------
Please add a case with templates, where `T` itself is the array type, maybe there are other fancy template tricks that could create an array implictly?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53771