[PATCH] D53595: [C++17] Reject shadowing of capture by parameter in lambda

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

In https://reviews.llvm.org/D53595#1276346, @Rakete1111 wrote:

> In https://reviews.llvm.org/D53595#1276330, @rsmith wrote:
>
> > In https://reviews.llvm.org/D53595#1273848, @Rakete1111 wrote:
> >
> > > Addresed review comments :)
> > >
> > > I updated the dr status file but a lot of unrelated changes made it in. Is this okay?
> >
> >
> > Please regenerate the file without your change and check that in as a separate commit prior to this.
>
>
> Why not afterwards? That way the DR is marked as resolved immediately.


That'd mean you need to track down an old version of the cwg_index.html file, though -- or guess what the relevant change to the HTML file would have been. Seems like more work that way. But the order of the two commits doesn't matter to me -- all I'm looking for is that the commit that resolves the DR /only/ changes that entry in cxx_dr_status.html, and the "rebase" on a new version of the issues list is done in a separate commit. (I don't know what you mean by "immediately"; I would expect the two commits to land within minutes of each other.)


Repository:
  rC Clang

https://reviews.llvm.org/D53595