[PATCH] D53586: Implement Function Multiversioning for Non-ELF Systems.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 25 11:23:39 PDT 2018


erichkeane added a comment.

In https://reviews.llvm.org/D53586#1276198, @rnk wrote:

> Here's a thought. What happens if different TUs observe different overload sets, perhaps because of ifdefs? Different TUs will generate different resolvers, but they won't dispatch to the same sets of targets. I'm guessing we'd treat that as an ODR violation, no diagnostic required?
>
> Anyway, I think this is ready to commit. Thanks!


Yep, pretty much. Its a bit of a weakness of the 'target' mv (since dispatch requires you to explicitly list), but I believe it is a trade off that gcc felt was acceptable.x`x`


https://reviews.llvm.org/D53586





More information about the cfe-commits mailing list