[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 25 08:26:26 PDT 2018


hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+        for (auto Type : Types) {
+          if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+            return false;
----------------
Considering that this is a local lambda called in one place, are we expecting cases where the canonical type is not something on which we can call getVectorKind()? If not, then we do not need this `if`.


https://reviews.llvm.org/D53417





More information about the cfe-commits mailing list